disable LLVM optimization on tests with long compilation times #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timings: imagenet 226s -> 52s wmt 63 -> 37s
|
ah, that's a good flag to know! |
andsteing
approved these changes
Dec 16, 2020
avital
added
Priority: P2 - no schedule
|
Just a quick Q: Should we also at least sometimes be running tests with LLVM optimization? Or do we assume that JAX core sufficiently tests that? |
|
For now LLVM passes are only disabled on tests where it is slow. You could argue both ways though. Once LLVM generates buggy code all bets are off really |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timings:
imagenet 226s -> 52s (timed before the model changed)
wmt 63 -> 37s